You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This won't make it to next is just to develop corel until the packages are updated in it's place
Adds sanity/ui and sanity/icons local packages to develop in corel until the new version are released.
Updates StatusButton and ImagePreviewStyled to have fallback values for not supported colors in deprecated sanity/ui theme v1.
What to review
Is it correct to include the new packages like this?
efps — editor "frames per second". The number of updates assumed to be possible within a second.
Derived from input latency. efps = 1000 / input_latency
Detailed information
🏠 Reference result
The performance result of sanity@latest
Benchmark
latency
p75
p90
p99
blocking time
test duration
article (title)
55ms
61ms
95ms
196ms
1065ms
14.4s
article (body)
19ms
22ms
63ms
207ms
486ms
6.3s
article (string inside object)
55ms
59ms
72ms
238ms
1360ms
9.3s
article (string inside array)
68ms
71ms
80ms
204ms
1930ms
10.2s
recipe (name)
34ms
37ms
44ms
66ms
78ms
9.3s
recipe (description)
30ms
34ms
37ms
97ms
79ms
6.5s
recipe (instructions)
7ms
8ms
10ms
24ms
0ms
3.4s
synthetic (title)
67ms
69ms
77ms
355ms
2304ms
17.3s
synthetic (string inside object)
63ms
67ms
73ms
627ms
2574ms
10.8s
🧪 Experiment result
The performance result of this branch
Benchmark
latency
p75
p90
p99
blocking time
test duration
article (title)
84ms
88ms
111ms
303ms
2706ms
17.0s
article (body)
19ms
23ms
57ms
238ms
436ms
6.4s
article (string inside object)
77ms
83ms
116ms
213ms
2477ms
11.5s
article (string inside array)
93ms
100ms
113ms
272ms
3408ms
12.4s
recipe (name)
50ms
52ms
79ms
125ms
849ms
11.9s
recipe (description)
47ms
48ms
58ms
76ms
625ms
7.8s
recipe (instructions)
6ms
8ms
9ms
11ms
18ms
3.5s
synthetic (title)
170ms
179ms
203ms
709ms
10193ms
29.2s
synthetic (string inside object)
163ms
171ms
187ms
747ms
9325ms
20.6s
📚 Glossary
column definitions
benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
test duration — how long the test run took to complete.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Note
This won't make it to
next
is just to develop corel until the packages are updated in it's placeAdds
sanity/ui
andsanity/icons
local packages to develop incorel
until the new version are released.Updates StatusButton and ImagePreviewStyled to have fallback values for not supported colors in deprecated sanity/ui theme v1.
What to review
Is it correct to include the new packages like this?
Testing
Existing tests should cover this change.
Notes for release
n/a